Improve ES migration test coverage #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call migration code instead of faking it.
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
zebot
added
the
ok-to-test
These were previously untested.
supersven
added a commit
that referenced
this pull request
Nov 22, 2024
... from #4346 These tests are supposed to fail as they show an incompatibility with OpenSearch (the bulk API of OS does not support "_version" tricks.) However, we need to get them green (or switch to ElasticSearch 7) to be able to use index migration jobs.
mdimjasevic
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call migration code instead of faking it.
Ticket: https://wearezeta.atlassian.net/browse/WPB-10715
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d